fix: Handle breaking change in Finch.stream API #813
Merged
+17
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yordis
reviewed
Nov 25, 2025
yordis
approved these changes
Nov 26, 2025
teamon
reviewed
Nov 26, 2025
| send(owner, {ref, :eof}) | ||
| end | ||
|
|
||
| if Application.spec(:finch, :vsn) >= ~c"0.20.0" do |
Member
There was a problem hiding this comment.
I'm late, but:
iex(2)> ~c"0.3.0" >= ~c"0.20.0"
true
Contributor
Author
There was a problem hiding this comment.
oh nice catch, and TIL about the Version module in the stdlib that seems ideal for this. I'll whip up a fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finch made a breaking change to the function signature for
Finch.stream/5here which was shipped in version0.20.0. This PR does conditional compilation of the response handler so that dialyzer is happy no matter which version of finch you're using.