feat!: update to MDEx 0.10 #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MDEx 0.10 has a few breaking changes which should have minimal impact on Tableau, but the larger change is that there is explicit support for plugins in MDEx, using the similar patterns as Req does. To simplify the use of plugins in Tableau, I have added a `plugins` key to `config.markdown.mdex` which is extracted and used to attach MDEx plugin modules prior to calling `MDEx.to_html!()`. This _could_ be implemented as a separate key `config.mdex_plugins`, but since it's part of the markdown converter, this felt more natural to me. If MDEx or one of its plugins adds a `plugins` option, this will break that -- but I think it's low probability.
halostatue
force-pushed
the
mdex-0-10-plugins
branch
from
e66bf71 to
f62776a
Compare
mhanberg
reviewed
Jan 8, 2026
mhanberg
reviewed
Jan 8, 2026
Co-authored-by: Mitchell Hanberg <[email protected]>
halostatue
commented
Jan 8, 2026
Refactor `MDExConverter.markdown/2` and `MDExConverter.convert/4` functions to use Keyword.pop for plugins. `MDExConverter.markdown/2` no longer tries to *merge* `:plugins`.
Ensure that the code is loaded before trying to call `mod.attach/1`.
Contributor
Author
|
Everything should be ready. I don't know if you use a ff-only/rebase merge process or a squash merge process, but if you prefer I can update the commits to be cleaner this evening. |
Collaborator
|
I only use squash merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MDEx 0.10 has a few breaking changes which should have minimal impact on Tableau, but the larger change is that there is explicit support for plugins in MDEx, using the similar patterns as Req does.
To simplify the use of plugins in Tableau, I have added a
pluginskey toconfig.markdown.mdexwhich is extracted and used to attach MDEx plugin modules prior to callingMDEx.to_html!().This could be implemented as a separate key
config.mdex_plugins, but since it's part of the markdown converter, this felt more natural to me. If MDEx or one of its plugins adds apluginsoption, this will break that -- but I think it's low probability.