Skip to content

Fix MatchError crash when TURN socket closes during allocation refresh #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
georgeday-firefly wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix MatchError crash when TURN socket closes during allocation refresh #91

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90d4d42
Fix TURN socket error handling
georgeday-firefly Jan 16, 2026
9be1c13
Merge branch 'elixir-webrtc:master' into master
georgeday-firefly Jan 16, 2026
a63c05e
Merge branch 'elixir-webrtc:master' into master
georgeday-firefly Jan 30, 2026
4de3304
Skip stale TURN timer messages for error-state clients
georgeday-firefly Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 27 additions & 4 deletions lib/ex_ice/priv/ice_agent.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -944,14 +944,28 @@ defmodule ExICE.Priv.ICEAgent do

{:send, dst, data, client} ->
tr = %{tr | client: client}
:ok = ice_agent.transport_module.send(tr.socket, dst, data)
put_in(ice_agent.gathering_transactions[tr_id], tr)

case ice_agent.transport_module.send(tr.socket, dst, data) do
:ok ->
put_in(ice_agent.gathering_transactions[tr_id], tr)

{:error, reason} ->
Logger.debug(
"Failed to send TURN message: #{inspect(reason)}. Closing transaction."
)

{_, ice_agent} = pop_in(ice_agent.gathering_transactions[tr_id])
update_gathering_state(ice_agent)
end

{:error, _reason, _client} ->
{_, ice_agent} = pop_in(ice_agent.gathering_transactions[tr_id])
update_gathering_state(ice_agent)
end

{nil, %{client: %{state: :error}}} ->
Copy link
Author

@georgeday-firefly georgeday-firefly Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a guard in handle_ex_turn_msg to skip relay candidates whose TURN client is already in :error state, preventing a FunctionClauseError in ExTURN.Client.handle_message/2 when stale Process.send_after timer messages (allocation refresh, permission refresh) are delivered after the client has errored out during teardown.

Copy link
Member

@sgfn sgfn Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd opt to add the missing function clause in ex_turn instead. Could you verify the patch from elixir-webrtc/ex_turn#9 works correctly?

ice_agent

{nil, cand} ->
case ExTURN.Client.handle_message(cand.client, msg) do
{:ok, client} ->
Expand All @@ -962,8 +976,17 @@ defmodule ExICE.Priv.ICEAgent do
cand = %{cand | client: client}
ice_agent = put_in(ice_agent.local_cands[cand.base.id], cand)
# we can't use do_send here as it will try to create permission for the turn address
:ok = ice_agent.transport_module.send(cand.base.socket, dst, data)
ice_agent
case ice_agent.transport_module.send(cand.base.socket, dst, data) do
:ok ->
ice_agent

{:error, reason} ->
Logger.debug(
"Failed to send TURN message: #{inspect(reason)}. Closing candidate."
)

close_candidate(ice_agent, cand)
end

{:error, _reason, client} ->
Logger.debug("""
Expand Down