Add Decimal support to Money.Ecto.Composite.Type#235
Open
EdoardoLopez wants to merge 1 commit intoelixirmoney:masterfrom
Open
Add Decimal support to Money.Ecto.Composite.Type#235EdoardoLopez wants to merge 1 commit intoelixirmoney:masterfrom
Money.Ecto.Composite.Type#235EdoardoLopez wants to merge 1 commit intoelixirmoney:masterfrom
Conversation
- Implement support for `Decimal` in the `load/1` function of `Money.Ecto.Composite.Type`.
| end | ||
| @spec load({integer() | Decimal.t(), atom() | String.t()}) :: {:ok, Money.t()} | ||
| def load({amount, currency}) when is_integer(amount), do: {:ok, Money.new(amount, currency)} | ||
| def load({%Decimal{} = amount, currency}), do: {:ok, amount |> Decimal.to_integer() |> Money.new(currency)} |
There was a problem hiding this comment.
Decimal.to_integer is not a safe conversion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #234 by adding support for
Decimalin theload/1function ofMoney.Ecto.Composite.Type. This change is similar to the resolution in issue #219, which also involved enhancing theload/1function for better type handling.