Skip to content

[FIX] Division for zero quotient with either a negative divisor or dividend #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmalovera10 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[FIX] Division for zero quotient with either a negative divisor or dividend #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4d17982
Merge pull request #1 from elixirmoney/master
jmalovera10 Sep 25, 2025
3bae6ac
fix: improve next_amount logic and add tests for Money.divide
Sep 25, 2025
5453164
test: add case for dividing zero by a negative number in Money.divide
Sep 25, 2025
4882d2d
test: add additional cases for Money.divide with negative divisors
Sep 25, 2025
ad08b3f
Merge branch 'fix/division-for-zero-quotient-with-either-a-divisor-or…
Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/money.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,8 @@ defmodule Money do
do_divide(currency, value, rem, count, acc)
end

defp next_amount(0, -1, count) when count > 0, do: -1
defp next_amount(0, rem, count) when count > 0 and rem < 0, do: -1
defp next_amount(0, rem, count) when count < 0 and rem > 0, do: -1
defp next_amount(value, 0, _count), do: value
defp next_amount(value, _rem, _count), do: increment_abs(value)

Expand Down
42 changes: 42 additions & 0 deletions test/money_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,11 @@ defmodule MoneyTest do
usd(-3)
]

assert Money.divide(Money.new(7, :USD), -2) == [
usd(-4),
usd(-3)
]

assert Money.divide(Money.new(-7, :USD), -2) == [
usd(4),
usd(3)
Expand All @@ -251,10 +256,47 @@ defmodule MoneyTest do
usd(0)
]

assert Money.divide(Money.new(1, :USD), -2) == [
usd(-1),
usd(0)
]

assert Money.divide(Money.new(-1, :USD), -2) == [
usd(1),
usd(0)
]

assert Money.divide(Money.new(-3, :USD), 5) == [
usd(-1),
usd(-1),
usd(-1),
usd(0),
usd(0)
]

assert Money.divide(Money.new(3, :USD), -5) == [
usd(-1),
usd(-1),
usd(-1),
usd(0),
usd(0)
]

assert Money.divide(Money.new(-3, :USD), -5) == [
usd(1),
usd(1),
usd(1),
usd(0),
usd(0)
]

assert Money.divide(Money.new(0, :USD), -5) == [
usd(0),
usd(0),
usd(0),
usd(0),
usd(0)
]
end

test "test div" do
Expand Down