chore: Clean up docker container and update tags#239
Merged
Conversation
kinson
approved these changes
Aug 1, 2025
btkostner
reviewed
Aug 1, 2025
Dockerfile
Outdated
| RUN mix compile | ||
|
|
||
| # Clean up unnecessary files after compilation to reduce image size | ||
| RUN rm -rf content \ |
Member
There was a problem hiding this comment.
Heads up, since this is only for building and the actual release layer is started down below FROM ${RUNNER_IMAGE}, this only changes the layer cache size. Not the final image size.
Member
Author
There was a problem hiding this comment.
Any suggestions you have are welcome. Doesn’t work as is, led to a 500 on fly
btkostner
approved these changes
Aug 1, 2025
doomspork
force-pushed
the
docker-improvements
branch
3 times, most recently
from
02e440c to
a7af370
Compare
doomspork
force-pushed
the
docker-improvements
branch
from
b732ece to
0533472
Compare
Member
Author
|
Expanded the scope of this PR a bit. Need to clear up the deployment issue and we should be good to go. |
Member
|
I had to upgrade to newer elixir and erlang versions, but verified this builds and runs. You'll probably need to comment out the docker build -t elixirschool .
docker run --rm -e SECRET_KEY_BASE=jCiY2GgNpsIvLErXTYogq7QwL9gDE2eM8C6wW/557l4BXP/4QE+qC19pgPiTgasq -e LIVE_VIEW_SALT=jCiY2GgNpsIvLErXTYogq7QwL9gDE2eM8C6wW/557l4BXP/4QE+qC19pgPiTgasq -p 4000:4000 -it elixirschool |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.