Conversation
ryonakano
force-pushed
the
ryonakano/flathub-feedback
branch
2 times, most recently
from
2e291d1 to
bb1ba49
Compare
Because they are ephemeral. Backport of flathub/flathub@17f7a12
…r DEs Modification of flathub/flathub@fcf24d6
ryonakano
force-pushed
the
ryonakano/flathub-feedback
branch
from
bb1ba49 to
247031c
Compare
| if (desktop_environment != "Pantheon") { | ||
| // Force elementary stylesheet to prevent broken UI on other DEs | ||
| gtk_settings.set_property ("gtk-theme-name", "elementary"); | ||
| gtk_settings.set_property ("gtk-icon-theme-name", "elementary"); |
There was a problem hiding this comment.
this syntax is unfamiliar to me. Gobject style does not work? Isnt the stylesheet named io.elementary.somethingsomething ?
taking your word for it, youve dealt with this more, but a bit surprised here
There was a problem hiding this comment.
I just copied and pasted commonly used patches on Flathub but as you mentioned the GObject-style property access should work and better. I'll follow up in the following PR. Thanks for pointing out!
There was a problem hiding this comment.
The "elementary" stylesheet points to the "io.elementary.blueberry" stylesheet.
There was a problem hiding this comment.
I just copied and pasted commonly used patches on Flathub but as you mentioned the GObject-style property access should work and better. I'll follow up in the following PR. Thanks for pointing out!
I commend your rigor and perfectionism, but this could be fixed in a code style sweep session. It is fine if you leave it as is. It isn't bad code.
The "elementary" stylesheet points to the "io.elementary.blueberry" stylesheet.
or i suppose to whatever accent someone may have for eOS?
thank you! Did not know that
2 participants
Fixes #434
Rebase-merged if desired.
You need to run
git submodule update --init --recursivefirst before building this branch on your local.Checklist
flatpak-builder builddir com.github.alecaddd.sequeler.json --force-clean --install --user --install-deps-from=appcenterflatpak-builder builddir build-aux/com.github.alecaddd.sequeler.json --force-clean --install --user --install-deps-from=flathub