fix: add mutex to prevent concurrent CGO access crashes #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sync.Mutexto serialize all exported CGO functionsProblem
When using the compiled shared library (
.so/.dylib) from .NET via P/Invoke, concurrent calls to exported functions cause segmentation faults (exit code 139). This happens because:chainIdvariable is written without synchronizationclient.GetClient()/client.CreateClient()functions use a non-thread-safe map internallySolution
Wrap all 19 exported functions with
mu.Lock()/defer mu.Unlock()to ensure only one thread can access the Go runtime state at a time.Testing
Tested with concurrent .NET threads (20 threads × 10 iterations = 200 concurrent signing operations) - all pass without crashes.