A hacky 'fix' for the scrolling bug - better'n'nothin'?#66
Open
colinta wants to merge 1 commit intoelm-community:masterfrom
Open
A hacky 'fix' for the scrolling bug - better'n'nothin'?#66colinta wants to merge 1 commit intoelm-community:masterfrom
colinta wants to merge 1 commit intoelm-community:masterfrom
Conversation
|
Thanks for this class ElmRescrollCommand(sublime_plugin.TextCommand):
def run(self, edit, prev_pos, t):
if t > 0:
if prev_pos == list(self.view.viewport_position()) :
sublime.set_timeout(lambda: self.run(edit, prev_pos, t-10), 10)
else:
self.view.set_viewport_position(prev_pos, False)and This still creates a blink on my computer but it better than the original solution in this patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #65. After running the 'elm-format' command, a timeout function scrolls to the previous viewport location, nothing more than that! I played with the timeout value until it consistently restored the scroll position.
Improvements: The viewport doesn't always scroll to the top, so a check of
viewport_positionwould help, but in my testing if the viewport didn't scroll this plugin didn't really have much effect.I didn't see any "on scroll" event on
EventListenerorViewEventListener, but another improvement would be a series of short timeouts, ~100ms, until a max timeout is reached (700-1000ms), and each timeout would check the position. That would restore the position as quickly as possible. But "perfect" is the enemy of "done" and I wanted to be done. 😉