Replace reinstall script with a simpler postinstall#55
Open
phillipj wants to merge 1 commit intoelm-community:masterfrom
Open
Replace reinstall script with a simpler postinstall#55phillipj wants to merge 1 commit intoelm-community:masterfrom
reinstall script with a simpler postinstall#55phillipj wants to merge 1 commit intoelm-community:masterfrom
Conversation
These changes are made for a couple of reasons: **Ideally running `npm install`** `npm install` is the de-facto way of installing dependencies in npm projects. The built-in install script has lifecycle scripts that allows us to perform actions *after* all npm dependencies has been installed for the project. npm ensures that dependencies installed which includes executable files are available in `$PATH` when npm scripts are run. In practise that means a custom `build` npm script might use `elm` as if it were globally installed on the machine, but it infact is a `devDependency` to that particular project. **Avoiding global dependencies** Ideally a project does not require global packages installed on the machine to run. This is cause of two reasons basically: - There is no good way to specify a system wide `dependency` and its version - A developer might want to run different versions of e.g. `elm` on different projects. By enforcing global installs, that's quite painful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
first of all, thanks for a great starter pack 👍 Hopefully I'm not stepping on any toes here, just want to suggest some changes after prior experiences over the years.
These changes are suggested for a couple of reasons:
Ideally running
npm installnpm installis the de-facto way of installing dependencies in npm projects.The built-in install script has lifecycle scripts that allows us to perform actions after all npm dependencies has been installed for the project.
npm ensures that dependencies installed which includes executable files are available in
$PATHwhen npm scripts are run. In practise that means a custombuildnpm script might useelmas if it were globally installed on the machine, but it infact is adevDependencyto that particular project.Avoiding global dependencies
Ideally a project does not require global packages installed on the machine to run. This is cause of two reasons basically:
dependencyand its versionelmon different projects. By enforcing global installs, that's quite painful.Any thoughts? Are there reasons the previous
reinstallexisted that I'm overlooking?