Merged
Conversation
miniBill
changed the title
lue-bird
requested changes
Mar 17, 2026
Collaborator
lue-bird
left a comment
lue-bird
left a comment
There was a problem hiding this comment.
looks great otherwise 👍
miniBill
force-pushed
the
cleanup-scanl-scanr
branch
from
9e7c2b3 to
30053ad
Compare
miniBill
force-pushed
the
cleanup-scanl-scanr
branch
from
30053ad to
ab4b5e4
Compare
lue-bird
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit avoids an unnecessary
case, the second one avoid non-tail recursive calls toscanr/scanr1