Skip to content

Commit 9c7d8a6

Browse files
authored
Merge pull request kubernetes#3363 from ellistarn/kubemark
[cluster-autoscaler] Fixes to Kubemark integration.
2 parents 2d8ba32 + e119e8e commit 9c7d8a6

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

cluster-autoscaler/cloudprovider/kubemark/kubemark_linux.go

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ package kubemark
2323

2424
import (
2525
"fmt"
26-
2726
apiv1 "k8s.io/api/core/v1"
2827
"k8s.io/apimachinery/pkg/api/resource"
2928
"k8s.io/autoscaler/cluster-autoscaler/cloudprovider"
@@ -36,6 +35,7 @@ import (
3635
"k8s.io/client-go/tools/clientcmd"
3736
"k8s.io/kubernetes/pkg/kubemark"
3837
schedulerframework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
38+
"os"
3939

4040
klog "k8s.io/klog/v2"
4141
)
@@ -197,7 +197,7 @@ func (nodeGroup *NodeGroup) Nodes() ([]cloudprovider.Instance, error) {
197197
return instances, err
198198
}
199199
for _, node := range nodes {
200-
instances = append(instances, cloudprovider.Instance{Id: ":////" + node})
200+
instances = append(instances, cloudprovider.Instance{Id: "kubemark://" + node})
201201
}
202202
return instances, nil
203203
}
@@ -313,9 +313,13 @@ func BuildKubemark(opts config.AutoscalingOptions, do cloudprovider.NodeGroupDis
313313
klog.Fatalf("Failed to get kubeclient config for external cluster: %v", err)
314314
}
315315

316-
kubemarkConfig, err := clientcmd.BuildConfigFromFlags("", "/kubeconfig/cluster_autoscaler.kubeconfig")
317-
if err != nil {
318-
klog.Fatalf("Failed to get kubeclient config for kubemark cluster: %v", err)
316+
// Use provided kubeconfig or fallback to InClusterConfig
317+
kubemarkConfig := externalConfig
318+
kubemarkConfigPath := "/kubeconfig/cluster_autoscaler.kubeconfig"
319+
if _, err := os.Stat(kubemarkConfigPath); !os.IsNotExist(err) {
320+
if kubemarkConfig, err = clientcmd.BuildConfigFromFlags("", kubemarkConfigPath); err != nil {
321+
klog.Fatalf("Failed to get kubeclient config for kubemark cluster: %v", err)
322+
}
319323
}
320324

321325
stop := make(chan struct{})

0 commit comments

Comments
 (0)