Replace FluentMigrator.Runner meta-package with FluentMigrator.Runner.Core#113
Merged
sfmskywalker merged 4 commits intomainfrom Jan 20, 2026
Merged
Conversation
- Changed Elsa.Persistence.Dapper to depend on FluentMigrator.Runner.Core instead of FluentMigrator.Runner (meta-package) - This prevents pulling in all database provider packages (Db2, Oracle, Postgres, SqlServer, Snowflake, etc.) - Removed UseSqlite() and UseSqlServer() convenience methods from DapperMigrationsFeature - Updated consuming applications to add specific runner packages and configure directly - Fixed pre-existing bug: replaced System.Data.SqlClient with Microsoft.Data.SqlClient package reference Co-authored-by: sfmskywalker <938393+sfmskywalker@users.noreply.github.com>
Co-authored-by: sfmskywalker <938393+sfmskywalker@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Replace FluentMigrator.Runner with FluentMigrator.Runner.Core
Replace FluentMigrator.Runner meta-package with FluentMigrator.Runner.Core
Jan 9, 2026
sfmskywalker
approved these changes
Jan 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #112 by replacing the FluentMigrator.Runner meta-package with FluentMigrator.Runner.Core in the Elsa.Persistence.Dapper library to avoid pulling in all database provider dependencies (~75+ MB of unused native dependencies). This is a breaking change that requires consuming applications to explicitly declare which database providers they need.
Changes:
- Replaced
FluentMigrator.RunnerwithFluentMigrator.Runner.Coredependency in core library - Removed
UseSqlite()andUseSqlServer()convenience methods fromDapperMigrationsFeature - Updated consuming application to explicitly configure database providers via
ConfigureRunner
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Directory.Packages.props | Added FluentMigrator.Runner.Core, FluentMigrator.Runner.SqlServer, and FluentMigrator.Runner.SQLite package versions (7.2.0) |
| src/modules/persistence/Elsa.Persistence.Dapper/Elsa.Persistence.Dapper.csproj | Replaced FluentMigrator.Runner with FluentMigrator.Runner.Core; replaced System.Data.SqlClient with Microsoft.Data.SqlClient |
| src/modules/persistence/Elsa.Persistence.Dapper/Features/DapperMigrationsFeature.cs | Removed UseSqlite() and UseSqlServer() convenience methods |
| src/workbench/Elsa.Server.Web/Elsa.Server.Web.csproj | Added explicit FluentMigrator.Runner.SqlServer and FluentMigrator.Runner.SQLite package references |
| src/workbench/Elsa.Server.Web/Program.cs | Updated migration configuration to use ConfigureRunner with explicit database provider calls |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/modules/persistence/Elsa.Persistence.Dapper/Features/DapperMigrationsFeature.cs
Outdated
Show resolved
Hide resolved
Member
|
@copilot apply changes based on the comments in this thread and make sure everything builds and tests pass. |
- Remove return statement from lambda in Program.cs (Action<T> should not return) - Add comprehensive XML documentation to ConfigureRunner property explaining breaking change and migration path Co-authored-by: sfmskywalker <938393+sfmskywalker@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR successfully addresses the issue where
Elsa.Persistence.Dapperdepends onFluentMigrator.Runnermeta-package, which transitively pulls in all database provider packages (Db2, Oracle, PostgreSQL, SQL Server, Snowflake, etc.), significantly increasing application size and publish time.Changes Made:
1. Core Library Changes (
Elsa.Persistence.Dapper)FluentMigrator.RunnerwithFluentMigrator.Runner.Corein project fileUseSqlite()andUseSqlServer()fromDapperMigrationsFeatureSystem.Data.SqlClientwithMicrosoft.Data.SqlClientConfigureRunnerproperty2. Package Management (
Directory.Packages.props)FluentMigrator.Runner.Core(7.2.0)FluentMigrator.Runner.SqlServer(7.2.0)FluentMigrator.Runner.SQLite(7.2.0)3. Consuming Application Updates (
Elsa.Server.Web)Benefits:
Breaking Change Notice:
DapperMigrationsFeature.UseSqlite()orUseSqlServer()methods.Migration Guide for Consumers:
Before:
After:
Testing:
Elsa.Persistence.DapperprojectFluentMigrator.Runner.Coreis now includedElsa.Server.WebworkbenchSecurity Summary:
No security vulnerabilities were introduced by these changes. The changes are purely dependency management and do not affect runtime behavior or data handling.
Addresses issue #112 raised by the community regarding FluentMigrator.Runner meta-package pulling all providers unnecessarily.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.