chore: Update ShowMessageBox to ShowMessageBoxAsync and upgrade package versions#760
Open
sfmskywalker wants to merge 27 commits intomainfrom
Open
chore: Update ShowMessageBox to ShowMessageBoxAsync and upgrade package versions#760sfmskywalker wants to merge 27 commits intomainfrom
ShowMessageBox to ShowMessageBoxAsync and upgrade package versions#760sfmskywalker wants to merge 27 commits intomainfrom
Conversation
… implementation in `RemoteActivityExecutionService`.
…tion support in left panel tabs
…nd update null initialization for fields
…abs`, streamline nested components, and enhance styling logic.
…t from `WorkflowInstanceWorkspace.razor`.
Introduced components and models to display a call stack for activity executions in the Workflow Instance Viewer. This includes UI elements for call stack rendering, error handling, and data integration with activity execution records.
…e it on activity selection changes
…elected` callbacks in `WorkflowInstanceViewer`
This refactor eliminates unused `ActivityExecutionSelected` callbacks and associated parameters across multiple components. It simplifies the codebase by removing redundant logic and dependencies related to activity execution selection while preserving core functionality.
Introduced the ability to pin the call stack, allowing it to remain fixed during navigation. Enhanced activity selection by optimizing early exits, preventing redundant calls, and adding logic for bidirectional highlighting within the current call stack.
…d streamline activity execution integration
Introduced a persistent drawer for execution details and refactored related components for better modularity and readability. Updated the data model and logic to streamline activity execution handling and display refreshed details dynamically.
Set `_isPinned` to true to ensure consistent pin behavior. Added checks and updates for activity execution details, improving null handling and refresh logic. Increased maximum receive message size to 5MB for hub connections.
…ne icon styling logic.
…ignerWrapper.razor.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…om `ActivityCallStack.razor`.
…eat/activity-call-stack
…r immutability in WorkflowInstanceWorkspace.razor.cs
…anceDesigner in WorkflowInstanceWorkspace.razor.cs for mutability purposes.
…ined UX Removed pinning feature and unused variables in `ActivityCallStack`. Refined drawer opening logic in `WorkflowInstanceViewer` for smoother interaction. Enhanced styling and streamlined event callbacks for better performance.
…ction handling Improved journal entry selection checks, added `_isSelectingFromJournal` flag to prevent unwanted activity selections, and refactored workflow execution log record selection logic with try-finally for consistent state management.
…andling Replaced `_isSelectingFromCallStack` and `_isSelectingFromJournal` flags with `_programmaticallySelectedNodeId` to streamline the handling of node selections and prevent unintended state changes.
…zation Added `_selectedEntry` to track selected call stack entries. Implemented virtualization in `ActivityCallStack.razor` to improve performance for long lists. Streamlined entry selection and clearing logic.
- Added functions to fetch custom and default activity names by ID. - Updated `Journal`, `ActivityCallStack`, and workflow viewer components to use these functions for consistent activity name presentation. - Enhanced UX by prioritizing designer activity name, with fallbacks to custom names and activity types.
…versions - Refactor calls to use `ShowMessageBoxAsync` for consistency and async operations. - Upgrade various package versions to improve dependency management and get latest features.
Greptile SummaryUpdated package dependencies to their latest versions and migrated code to be compatible with MudBlazor 9.0 breaking changes. The migration systematically replaces deprecated Key changes:
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| Directory.Packages.props | Updates package versions: MudBlazor 8.15.0→9.0.0, Radzen 8.3.5→9.0.5, Microsoft packages to latest patches, reorganizes Refit packages by target framework |
| src/modules/Elsa.Studio.Workflows/ActivityPickers/Treeview/ActivityPicker.razor.cs | Adapts to MudBlazor 9.0 API changes: uses ITreeItemData<string>, adds null-safety operators, removes unnecessary null-conditional operators on non-nullable properties |
| src/modules/Elsa.Studio.Workflows/Components/WorkflowDefinitionList/WorkflowDefinitionList.razor.cs | Migrates ShowMessageBox to ShowMessageBoxAsync (5 occurrences) for MudBlazor 9.0 compatibility |
| src/modules/Elsa.Studio.Workflows/Components/WorkflowInstanceList/WorkflowInstanceList.razor.cs | Migrates ShowMessageBox to ShowMessageBoxAsync (3 occurrences) for MudBlazor 9.0 compatibility |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[MudBlazor 8.15.0] --> B[Upgrade to MudBlazor 9.0.0]
B --> C{API Breaking Changes}
C --> D[ShowMessageBox deprecated]
C --> E[TreeItemData API changes]
D --> F[Update all DialogService calls]
F --> G[Labels.razor.cs]
F --> H[InputsSection.razor.cs]
F --> I[OutputsSection.razor.cs]
F --> J[VariablesTab.razor.cs]
F --> K[VersionHistoryTab.razor.cs]
F --> L[WorkflowDefinitionList.razor.cs]
F --> M[WorkflowInstanceList.razor.cs]
G --> N[ShowMessageBox → ShowMessageBoxAsync]
H --> N
I --> N
J --> N
K --> N
L --> N
M --> N
E --> O[ActivityPicker.razor.cs]
O --> P[TreeItemData → ITreeItemData]
O --> Q[Add null-safety operators]
O --> R[Remove unnecessary null-conditionals]
N --> S[All components updated]
P --> S
Q --> S
R --> S
S --> T[MudBlazor 9.0 compatible]
Last reviewed commit: b21302f
…`ActivityPicker.razor` - Update package version for `CodeBeam.MudBlazor.Extensions` to leverage new features. - Refactor `ActivityPicker.razor` for improved localization handling and consolidation of logic. - Simplify `ActivityTreeItem` constructor by integrating `ChildrenList`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Updates packages.
Scope
Select one primary concern:
Description
Problem
Keep packages up to date.
Solution
Updated the packages.
Verification
See if the build succeeds and smoke test the Elsa Studio app.
Expected outcome:
No noticeable changes.
Screenshots / Recordings (if applicable)
Commit Convention
We recommend using conventional commit prefixes:
fix:– Bug fixes (behavior change)feat:– New featuresrefactor:– Code changes without behavior changedocs:– Documentation updateschore:– Maintenance, tooling, or dependency updatestest:– Test additions or modificationsClear commit messages make reviews easier and history more meaningful.
Checklist