[HOTFIX] - Implement better handling of LIMIT/OFFSET in MSSQL driver#45
Merged
[HOTFIX] - Implement better handling of LIMIT/OFFSET in MSSQL driver#45
Conversation
alankoroma
previously approved these changes
Oct 21, 2025
Mr-Kaos
approved these changes
Nov 4, 2025
alankoroma
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
TableandMssqlwith special behaviour for the MSSQL driver to address #44.Problem
MSSQL has multiple ways of selecting a limited number of rows.
SELECT TOP n [columns] FROM...whereOFFSETandORDER BYcan be omittedOFFSET n FETCH NEXT r ROWS ONLYwhere both an offset and limit must be specifiedThe
OFFSETclause can also be used without a limit, so long as anORDER BYis specified.Currently, queries that are generated where only a limit is specified break because an
OFFSETclause isn't added.Solution
The
Tableclass adds aTOP nmodifier to the selected columns list when only a limit is specified, without an offset. In cases where both an offset and limit are specified, the original behaviour remains with a no-opORDER BYbeing added if missing.