Begin adding types, starting with $pdo on the Driver classes.#48
Open
rrigby wants to merge 5 commits intoelvanto:masterfrom
Open
Begin adding types, starting with $pdo on the Driver classes.#48rrigby wants to merge 5 commits intoelvanto:masterfrom
rrigby wants to merge 5 commits intoelvanto:masterfrom
Conversation
Make $pdo private and create a setter method Make getConnection throw an exception is $pdo is null
…e are '?' in the query. (very unlikely, but keeps psalm happy)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR in an attempt to slowly bring types into this library. There's some key areas that need to be tackled manually first like this before I can bring in automated tooling like Rector.
I typed
$pdoas?PDO, made it private and updated all usages to access it viagetConnection().I've added a
setConnection()method to allow children to set it.I've opted to make
getConnection()throw an exception if the connection isn't established.This was the least intrusive change as this maintains the existing contract all the code was working under, that it always returns
PDO.Other small fixes:
$requiredAttributesand$schemaTable)getSqlFromPreparedStatementthat would occur if there were more items in$valuesthan '?' in$sql(Unlikely to actually happen, but Psalm picked it up)