Skip to content

fix: Wrongful generation of Date type #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Wrongful generation of Date type #182

wants to merge 2 commits into from

Conversation

mikkelam
Copy link

@mikkelam mikkelam commented Jan 3, 2025

This fixes that we're generating objects of type: Date which is not a valid OpenAPI data type see docs.

I also added a test to verify that it works as expected.

Let me know if i should change anything

@marclave marclave self-requested a review January 15, 2025 18:13
marclave
marclave approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@marclave marclave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @mikkelam !

@mrctrifork
Copy link

@SaltyAom is there a reason why this cannot be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marclave marclave marclave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikkelam @mrctrifork @marclave