Skip to content

Fix graceful shutdown not awaiting server.stop #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −5
Open

Fix graceful shutdown not awaiting server.stop #1455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55b7a16
add await for stop
LeTamanoir Oct 2, 2025
26c3601
nit
LeTamanoir Oct 2, 2025
b77abcd
fix test
LeTamanoir Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/adapter/bun/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,9 +381,9 @@ export const BunAdapter: ElysiaAdapter = {

if (callback) callback(app.server!)

process.on('beforeExit', () => {
process.on('beforeExit', async () => {
if (app.server) {
app.server.stop?.()
await app.server.stop?.()
app.server = null

if (app.event.stop)
Expand Down Expand Up @@ -416,7 +416,7 @@ export const BunAdapter: ElysiaAdapter = {
},
async stop(app, closeActiveConnections) {
if (app.server) {
app.server.stop(closeActiveConnections)
await app.server.stop(closeActiveConnections)
app.server = null

if (app.event.stop?.length)
Expand Down
2 changes: 1 addition & 1 deletion src/adapter/web-standard/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export const WebStandardAdapter: ElysiaAdapter = {
)

if (app.server) {
app.server.stop(closeActiveConnections)
await app.server.stop(closeActiveConnections)
app.server = null

if (app.event.stop?.length)
Expand Down
2 changes: 1 addition & 1 deletion test/ws/aot.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ describe('WebSocket with AoT disabled', () => {
await wsOpen(ws)
await wsClosed(ws)

await app.stop()
await app.stop(true)
})
})
Loading