Skip to content

fix: write transformed cookie value to cookie entry directly#1795

Merged
SaltyAom merged 1 commit intoelysiajs:mainfrom
MegaManSec:j4
Mar 16, 2026
Merged

fix: write transformed cookie value to cookie entry directly#1795
SaltyAom merged 1 commit intoelysiajs:mainfrom
MegaManSec:j4

Conversation

@MegaManSec
Copy link
Contributor

@MegaManSec MegaManSec commented Mar 10, 2026

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Fixed a bug in cookie value assignment during validation and decoding operations to ensure cookie values are processed correctly.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 184816e2-f9e2-4842-aa9c-aa4e034d43d1

📥 Commits

Reviewing files that changed from the base of the PR and between 169e54a and 9ae4b02.

📒 Files selected for processing (1)
  • src/compose.ts

Walkthrough

A single-line correction in the cookie validation decoding logic that adjusts the assignment path from c.cookie[key].cookie.value to c.cookie[key].value, fixing how decoded cookie values are stored in the cookie object.

Changes

Cohort / File(s) Summary
Cookie Decoding Fix
src/compose.ts
Corrected property access path in cookie value assignment within TransformDecodeError handling, removing redundant .cookie property access.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A cookie path once nested deep,
With extra layers to decode and keep,
Now simplified to its rightful place,
Values assigned with better grace! 🍪✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing how transformed cookie values are assigned directly to cookie entries instead of nested properties.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 16, 2026

Open in StackBlitz

npm i https://pkg.pr.new/elysia@1795

commit: 9ae4b02

@SaltyAom SaltyAom merged commit 135a2ee into elysiajs:main Mar 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants