Update utils so the benchmark is not optimized out#21
Open
hpcdisrespecter wants to merge 1 commit intoelysiajs:mainfrom
Open
Update utils so the benchmark is not optimized out#21hpcdisrespecter wants to merge 1 commit intoelysiajs:mainfrom
hpcdisrespecter wants to merge 1 commit intoelysiajs:mainfrom
Conversation
- benchmark was likely optimized out (dead code elimination) = ! - https://github.com/evanwashere/mitata#writing-good-benchmarks
|
The mitata docs show that a value should be passed into the do_not_optimize function. Not a closure. Are you sure that closure is really executed by mitata? |
Author
|
I'm not sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, warning is emitted by test harness: