Fix jump-list buffer mode-name and select-action.#1996
Open
mychris wants to merge 1 commit intoemacs-evil:masterfrom
Open
Fix jump-list buffer mode-name and select-action.#1996mychris wants to merge 1 commit intoemacs-evil:masterfrom
mychris wants to merge 1 commit intoemacs-evil:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The property for the
mode-nameis:mode-nameinevil-common.el, but:modeinevil-jumps.el. Changed it inevil-jumps.el, so that themode-namein jump-list buffers is set correct.For local variables, they are killed if a major-mode gets set, if the variable is not marked as
permanent-local.See
(info "(emacs) Locals"):Since all the variables in
tabulated-listare marked as permanent locals, I markedevil-list-view-select-actionas well. In addition, I moved the initialization ofevil-list-view-select-actionafter switching toevil-list-view-mode, just to be sure.This also fixes the
:select-actionofevil-show-marksbuffers.