Skip to content

chore: Compatible to latest github-tags #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2022
Merged

chore: Compatible to latest github-tags #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions lsp-ltex.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,9 @@ This must be a positive integer."

(defcustom lsp-ltex-completion-enabled nil ;; TODO: Add proper implementation
"If this this is enabled, auto-completion list for the current word is sent.
The editor need to send a completion request.")
The editor need to send a completion request."
:type 'boolean
:group 'lsp-ltex)

(defcustom lsp-ltex-diagnostic-severity "information"
"Severity of the diagnostics corresponding to the grammar and spelling errors."
Expand Down Expand Up @@ -259,8 +261,6 @@ The editor need to send a completion request.")
;; (@* "Externals" )
;;

(defvar github-tags-names)

(declare-function github-tags "ext:github-tags.el")

;;
Expand Down Expand Up @@ -386,15 +386,17 @@ This is use to active language server and check if language server's existence."

(defun lsp-ltex--latest-version ()
"Return the latest version from remote repository."
(when (and (featurep 'github-tags) (ignore-errors (github-tags lsp-ltex-repo-path)))
(let ((index 0) version ver)
;; Loop through tag name and fine the stable version
(while (and (not version) (< index (length github-tags-names)))
(setq ver (nth index github-tags-names)
index (1+ index))
(when (string-match-p "^[0-9.]+$" ver) ; stable version are only with numbers and dot
(setq version ver)))
version)))
(when (featurep 'github-tags)
(when-let ((response (ignore-errors (github-tags lsp-ltex-repo-path))))
(let ((names (plist-get (cdr response) :names))
(index 0) version ver)
;; Loop through tag name and fine the stable version
(while (and (not version) (< index (length names)))
(setq ver (nth index names)
index (1+ index))
(when (string-match-p "^[0-9.]+$" ver) ; stable version are only with numbers and dot
(setq version ver)))
version))))

(defun lsp-ltex--lsp-dependency ()
"Register LSP dependency once."
Expand Down