Extend loading of VSCode code-workspace files for Java workspaces #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I find myself often loading vscode workspaces with multiple Java projects that have dependencies between one another, and require the use of custom Java runtimes and debugging settings. Because of the way JDTLS works, the dependent project folders need to be "open" in the session at the same time, even though I don't usually have files from all projects open, so I add them into the jdtls hash. For the runtimes and debug settings, I just read from the code-workspace file's json config.
Author
|
Looks to me like the failure is just a network problem? |
jcs090218
reviewed
Nov 12, 2025
| (lsp-session-server-id->folders (lsp-session)))))) | ||
| (lsp-session-folders (lsp-session)))) | ||
|
|
||
| (advice-add #'lsp-load-vscode-workspace :after #'lsp-java--load-vscode-workspace) |
Member
There was a problem hiding this comment.
I'm a bit concerned that using advice-add might be too aggressive. 🤔 It could potentially introduce side effects for other LSP clients.
Author
There was a problem hiding this comment.
yeah, true. alternatively we just make it a new lsp-java-load-vscode-workspace function that calls the lsp-load-vscode-workspace itself, and then I just add that to the documentation?
Member
There was a problem hiding this comment.
Yeah, I think that's probably the best approach for now. 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find myself often loading vscode workspaces with multiple Java projects that have dependencies between one another, and require the use of custom Java runtimes and debugging settings.
Because of the way JDTLS works, the dependent project folders need to be "open" in the session at the same time, even though I don't usually have files from all projects open, so I add them into the jdtls hash. For the runtimes and debug settings, I just read from the code-workspace file's json config.