Skip to content

fix: Ignore persist when lsp-session-file is nil #4888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Ignore persist when lsp-session-file is nil #4888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.org
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
* Make lsp-headerline--check-breadcrumb public
* Added Odin langauge server support [[https://github.com/DanielGavin/ols][ols]]
* Fix bug in lsp-odin where ~f-join~ collapses double slashes. Using ~format~ instead.
* Fix bug where persist was attempted when lsp-session-file is nil

** 9.0.0
* Add language server config for QML (Qt Modeling Language) using qmlls.
Expand Down
11 changes: 7 additions & 4 deletions lsp-mode.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9380,10 +9380,13 @@ The library folders are defined by each client for each of the active workspace.

(defun lsp--persist-session (session)
"Persist SESSION to `lsp-session-file'."
(lsp--persist lsp-session-file (make-lsp-session
:folders (lsp-session-folders session)
:folders-blocklist (lsp-session-folders-blocklist session)
:server-id->folders (lsp-session-server-id->folders session))))
(if lsp-session-file
(lsp--persist lsp-session-file (make-lsp-session
:folders (lsp-session-folders session)
:folders-blocklist (lsp-session-folders-blocklist session)
:server-id->folders
(lsp-session-server-id->folders session)))
(message "lsp-session-file is nil, not persisting session.")))

(defun lsp--try-project-root-workspaces (ask-for-client ignore-multi-folder)
"Try create opening file as a project file.
Expand Down