Skip to content

lsp-ui-sideline: display all code actions of the current diagnostics #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2025
Merged

lsp-ui-sideline: display all code actions of the current diagnostics #790

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7d7072
lsp-ui-sideline: display all code actions of the current diagnostics
taquangtrung Aug 4, 2025
88a3484
use LSP APIs to get diagnostics locations to account for LSP_USE_PLISTS
taquangtrung Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions lsp-ui-sideline.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,13 +619,26 @@ from the language server."
(lsp--registered-capability "textDocument/codeAction")))
(lsp-request-async
"textDocument/codeAction"
(-let (((start . end) (if (eq lsp-ui-sideline-update-mode 'line)
(cons 0 (- eol bol))
(--> (- (point) bol) (cons it it)))))
(-let* ((diagnostics (lsp-ui-sideline--line-diags (1- line-widen)))
((start . end) (cond ((eq lsp-ui-sideline-update-mode 'line)
(cons 0 (- eol bol)))
(diagnostics
(let* ((start (- (point) bol))
(end start))
(mapc
(-lambda
((&Diagnostic
:range (&Range :start (&Position :character c1)
:end (&Position :character c2))))
(setq start (min c1 start))
(setq end (max c2 end)))
diagnostics)
(cons start end)))
(t (--> (- (point) bol) (cons it it))))))
(list :textDocument doc-id
:range (list :start (list :line (1- line-widen) :character start)
:end (list :line (1- line-widen) :character end))
:context (list :diagnostics (lsp-ui-sideline--line-diags (1- line-widen)))))
:context (list :diagnostics diagnostics)))
(lambda (actions)
(when (eq (current-buffer) buffer)
(lsp-ui-sideline--code-actions actions bol eol)))
Expand Down
Loading