Skip to content

Conversation

@CeleritasCelery
Copy link
Contributor

See #77

This change does three things:

First it adds a prefix argument to the recompile and rerun commands so the cargo command can be edited before running.

Second it adds a new function rustic-cargo-test-rerun-current, that can be called from a rustic-cargo-test-mode buffer to rerun the test at point. Bound to C-c C-t by default.

Third, it adds minibuffer history support to the cargo-run-* and cargo-test-* commands.

See #77

This change does three things:

First it adds a prefix argument to the `recompile` and `rerun` commands so the cargo command can be
edited before running.

Second it adds a new function `rustic-cargo-test-rerun-current`, that can be called from a
`rustic-cargo-test-mode` buffer to rerun the test at point. Bound to `C-c C-t` by default.

Third, it adds minibuffer history support to the cargo-run-* and cargo-test-* commands.
Copy link
Contributor

@shepmaster shepmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm only reviewing based on user functionality, not code quality)

a prefix argument to the recompile and rerun commands so the cargo command can be edited before running

Perfect, this is the primary thing I was looking for, and my muscle memory thanks you!

a new function rustic-cargo-test-rerun-current, that can be called from a rustic-cargo-test-mode buffer to rerun the test at point

Wonderful! This was my stretch wish, so it's exciting to see you were able to implement it. I might choose to rebind this to something shorter (t, maybe?).

minibuffer history support to the cargo-run-* and cargo-test-* commands

Oh good, I was wondering where that was and thought that I had broken something in my configuration.

Copy link
Member

@psibi psibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I wonder if we can improve the README about these workflows. I think it's hard for beginners to see if such an workflow exits.

@CeleritasCelery CeleritasCelery merged commit 4404bdb into main Jan 30, 2025
3 checks passed
@CeleritasCelery CeleritasCelery deleted the recompile branch January 30, 2025 19:03

Keybinding | Command
------------------------|----------------------
<kdb>C-c C-p</kdb> | rustic-popup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these supposed to be kbd?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes... 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants