Skip to content

yaml/highlights.scm: Treat plain value with string face#196

Open
cldotdev wants to merge 1 commit intoemacs-tree-sitter:masterfrom
cldotdev:fix/yaml
Open

yaml/highlights.scm: Treat plain value with string face#196
cldotdev wants to merge 1 commit intoemacs-tree-sitter:masterfrom
cldotdev:fix/yaml

Conversation

@cldotdev
Copy link
Copy Markdown

The plain value (without quotes) in a YAML file is treated as a string. Therefore, its font face should match that of the quoted string

Original appearance:

圖片

After the fix, it looks like:

圖片

@meain
Copy link
Copy Markdown
Member

meain commented Aug 18, 2023

I think not highlighting it is how yaml-mode does it by default. Looking at neovim implementation, it seems to be the same as well. And so, I personally think we should leave it as is.

@cldotdev
Copy link
Copy Markdown
Author

The plain text is highlighted by default in VS Code. However, I agree to leave it as it is if the package strictly follows the original design of yaml-mode.

圖片

圖片

@meain
Copy link
Copy Markdown
Member

meain commented Aug 21, 2023

I agree to leave it as it is if the package strictly follows the original design of yaml-mode.

The package AFAICT does not strictly follow the design of yaml-mode. That said, I personally don't think deviating from it brings us anything more in this specific case. I don't have any strong opinions on this. I'll leave it to @ubolonton on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants