Upgrade ESLint and swap to eslint.config.js #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simultaneously upgrades cross-spawn to a secure version
Member
|
@n-older what do we do regarding the CI failing now for Node 14 and 16? Or should we just drop support for those in the CI? |
Contributor
Author
Hmm I didn't know about these tests beforehand. I mean it's just a dev dependency so maybe we just axe these older version tests. |
Member
|
@n-older I think we can cause 14 and 16 are so old anyway. Remove them from the actions config in this PR and that'll solve it. |
Contributor
Author
|
Did I do that correctly? Not sure why they're still showing for me unless it's some weird GitHub bug. |
jclusso
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also simultaneously upgrades cross-spawn to a secure version since eslint depends on it.