Skip to content

Duplicate params to avoid modifying input hash #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danarnold merged 3 commits into from
Jun 4, 2025
Merged

Duplicate params to avoid modifying input hash #19

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4145c74
dup params to avoid modifying input hash, bump version
danarnold Jun 4, 2025
f2a03c8
rename params dup variable to params_copy. add test. remove version b…
danarnold Jun 4, 2025
2e64c6e
simplify params empty check in query set
danarnold Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions lib/emailable/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ def initialize
end

def request(method, endpoint, params = {})
api_key = params.delete(:api_key)
access_token = params.delete(:access_token)
req_params = params.dup
api_key = req_params.delete(:api_key)
access_token = req_params.delete(:access_token)

uri = URI("#{@base_url}/#{endpoint}")
headers = {
Expand All @@ -30,12 +31,12 @@ def request(method, endpoint, params = {})
tries ||= 3
http_response =
if method == :get
uri.query = URI.encode_www_form(params) unless params.empty?
uri.query = URI.encode_www_form(req_params) unless req_params.empty?
request = Net::HTTP::Get.new(uri, headers)
@connection.request(request)
elsif method == :post
request = Net::HTTP::Post.new(uri, headers)
request.body = params.to_json
request.body = req_params.to_json
@connection.request(request)
end

Expand Down
2 changes: 1 addition & 1 deletion lib/emailable/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Emailable
VERSION = '4.2.1'
VERSION = '4.2.2'
end
Loading