Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves how model dependencies are managed and configures property scanning for Spring Boot applications in both the Java and Kotlin example projects. It makes Ollama the default always-included model backend, while OpenAI and Anthropic dependencies are now activated only if the corresponding API keys are set. Additionally, it updates the Spring Boot configuration to use
@ConfigurationPropertiesScanfor property binding. The environment check script is also updated to better handle missing API keys.Dependency management improvements:
examples-java/pom.xmlandexamples-kotlin/pom.xml. OpenAI and Anthropic dependencies are removed from the default dependencies and instead added under Maven profiles that activate only if the respective API keys are present in the environment (OPENAI_API_KEY,ANTHROPIC_API_KEY). [1] [2] [3] [4]Spring Boot configuration enhancements:
@EnableConfigurationPropertieswith@ConfigurationPropertiesScan(scanning thecom.embabel.examplepackage) in all Java and Kotlin example applications to improve property binding and configuration. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Other improvements:
scripts/support/check_env.bat) to remove API key instructions and clarify that Ollama will be used if both API keys are missing, with a reminder to check Ollama installation and set the default model. [1] [2]JavaAgentMcpServerApplicationtoKotlinAgentMcpServerApplication. [1] [2]