Textarea: readEditor(): call callback after editing#8
Open
plepe wants to merge 1 commit intoembarklabs:masterfrom
Open
Textarea: readEditor(): call callback after editing#8plepe wants to merge 1 commit intoembarklabs:masterfrom
plepe wants to merge 1 commit intoembarklabs:masterfrom
Conversation
plepe
force-pushed
the
textarea-readeditor
branch
from
c8545e1 to
37e93a4
Compare
GottZ
suggested changes
Jan 30, 2019
GottZ
left a comment
GottZ
left a comment
There was a problem hiding this comment.
after looking at the whole file i suggest adding a return statement in front of that callback call. return callback(null, value);
plepe
force-pushed
the
textarea-readeditor
branch
from
37e93a4 to
0ac6527
Compare
Author
|
Does not really change anything, but yes - why not. I modified the commit and force-pushed the change. |
GottZ
approved these changes
Feb 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed, that the
readEditor()callback on the Textarea widget won't be called after closing the external editor. This little change fixes this problem.