Layers #54
Layers #54
Conversation
src/layer/ReshapeLayer.cpp
Outdated
| if (input.data.size() != output.data.size()) { | ||
| throw std::runtime_error("ReshapeLayerMock: Input and output data buffer sizes mismatch."); | ||
| } | ||
| std::fill(output.data.begin(), output.data.end(), static_cast<double>(getID()) + 0.9); |
There was a problem hiding this comment.
Please, replace stub implementations with throw std::logic_error("Not yet implemented");
|
|
||
| # REPORT | ||
| message( STATUS "") | ||
| message( STATUS "General configuration for ${PROJECT_NAME}") | ||
| message( STATUS "======================================") | ||
| message( STATUS "") | ||
| message( STATUS " Configuration: ${CMAKE_BUILD_TYPE}") | ||
| message( STATUS "") |
| include(FetchContent) | ||
| FetchContent_Declare( | ||
| googletest | ||
| GIT_REPOSITORY https://github.com/google/googletest.git | ||
| GIT_TAG v1.14.0 | ||
| ) | ||
| FetchContent_MakeAvailable(googletest) | ||
|
|
||
|
|
||
| #add_subdirectory(3rdparty/googletest) |
There was a problem hiding this comment.
We already have googletest integrated, why do we need this? Please, revert
| @@ -1,15 +1,30 @@ | |||
| cmake_minimum_required(VERSION 3.20) | |||
| set(CMAKE_CXX_STANDARD 11) | |||
There was a problem hiding this comment.
C++11 is too low. If you need to specify the standard then it should be at least 17.
There was a problem hiding this comment.
I'm not sure that changes in this file are required. It could be reverted as well
| target_link_libraries(run_tests PUBLIC | ||
| gtest_main | ||
| ) | ||
| file(GLOB_RECURSE TEST_FILES ./*.cpp) |
There was a problem hiding this comment.
Please, avoid using relative paths, use ${CMAKE_CURRENT_SOURCE_DIR} for referencing current directory
|
|
||
| project(cpp_template) | ||
|
|
||
| include(cmake/configure.cmake) |
There was a problem hiding this comment.
why cmake/configure.cmake was excluded? some useful settings are listed there (e.g. including standard)
2 participants
No description provided.