fix: prevent integer overflow in kernel heap allocations - #39
Merged
srpatcha merged 1 commit intoAug 25, 2026
Merged
Conversation
AlbiKallaba
requested review from
hshanmug12,
maheshmunnangi and
srpatcha
as code owners
August 24, 2026 12:10
srpatcha
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
eos_malloc()aligns the requested size and then adds the internal block-header size without first checking whether either calculation can overflowsize_t.For requests close to
SIZE_MAX, the arithmetic can wrap to a small value. The allocator may then return a valid-looking pointer to a block that is much smaller than requested, potentially leading to out-of-bounds writes.The heap implementation was also not included in the
eos_kernelCMake target, despite the allocator API being publicly exposed.Solution
HEADER_SIZE.kernel/src/mem/heap.cto theeos_kerneltarget.SIZE_MAX, alignment overflow, and a valid allocation after rejected requests.Testing
Built and executed the dedicated test on a Windows host using CMake, Ninja, and Zig/Clang 21:
cmake --build build/codex --target test_heapctest --test-dir build/codex -R "^test_heap$" --output-on-failureResult:
100% tests passed, 1/1The regression test was run against the previous implementation and failed with:
SIZE_MAX allocation must be rejectedAdditional considerations
This change only rejects unrepresentable allocation sizes. It does not change the allocator's best-fit, splitting, coalescing, or statistics behavior.