Fixes require-ember-lifeline rule to scope it to only ember file types (#93)

* Fixes require-ember-lifeline rule to scope it to only ember file types

Author: scalvert

lib/rules/require-ember-lifeline.js

@@ -6,6 +6,7 @@ const { getCaller, cleanCaller } = require('../utils/caller');
 const { getEmberImportBinding } = require('../utils/imports');
 const { collectObjectPatternBindings } = require('../utils/destructed-binding');
 
+const LINTABLE_FILE_PATTERNS = /\/components|routes|controllers|services\//i;
 let DISALLOWED_OBJECTS = ['Ember.run', 'run'];
 let RUN_METHODS = ['later', 'next', 'debounce', 'throttle'];
 const LIFELINE_METHODS = ['runTask', 'runTask', 'debounceTask', 'throttleTask'];
@@ -28,6 +29,10 @@ function mergeDisallowedCalls(objects) {
     }, []);
 }
 
+function isLintableFile(context) {
+  return LINTABLE_FILE_PATTERNS.test(context.eslint.getFilename());
+}
+
 module.exports = {
   docs: {
     description: 'Please use the lifecycle-aware tasks from ember-lifeline instead of Ember.run.*.',
@@ -61,6 +66,10 @@ module.exports = {
       MemberExpression(node) {
         let caller = cleanCaller(getCaller(node));
 
+        if (!isLintableFile(context)) {
+          return;
+        }
+
         if (disallowedCalls.includes(caller)) {
           context.report(node, getMessage(caller));
         }

package.json

@@ -29,7 +29,7 @@
     "eslint": "^3.11.1",
     "mocha": "^3.2.0",
     "mocha-eslint": "^3.0.1",
-    "nyc": "^10.0.0"
+    "nyc": "^11.2.1"
   },
   "dependencies": {
     "requireindex": "^1.1.0"

tests/lib/rules/require-ember-lifeline.js

@@ -7,10 +7,13 @@ const ruleTester = new RuleTester({
     sourceType: 'module'
   }
 });
+const filename = 'addon/components/my-component.js';
+const unlintableFilename = 'addon/utils/util.js';
 
 ruleTester.run('require-ember-lifeline', rule, {
   valid: [
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -23,6 +26,7 @@ ruleTester.run('require-ember-lifeline', rule, {
         });`
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -37,6 +41,7 @@ ruleTester.run('require-ember-lifeline', rule, {
         });`
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -49,6 +54,7 @@ ruleTester.run('require-ember-lifeline', rule, {
         });`
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -63,6 +69,7 @@ ruleTester.run('require-ember-lifeline', rule, {
         });`
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -75,6 +82,7 @@ ruleTester.run('require-ember-lifeline', rule, {
         });`
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -87,10 +95,26 @@ ruleTester.run('require-ember-lifeline', rule, {
             }
           }
         });`
+    },
+    {
+      filename: unlintableFilename,
+      code: `
+        import Ember from 'ember';
+
+        export default Ember.Component({
+          actions: {
+            foo() {
+              Ember.run.later(() => {
+                doSomeWork();
+              });
+            }
+          }
+        });`
     }
   ],
   invalid: [
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -106,6 +130,7 @@ ruleTester.run('require-ember-lifeline', rule, {
       }]
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -123,6 +148,7 @@ ruleTester.run('require-ember-lifeline', rule, {
       }]
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -138,6 +164,7 @@ ruleTester.run('require-ember-lifeline', rule, {
       }]
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -155,6 +182,7 @@ ruleTester.run('require-ember-lifeline', rule, {
       }]
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -174,6 +202,7 @@ ruleTester.run('require-ember-lifeline', rule, {
       }]
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -195,6 +224,7 @@ ruleTester.run('require-ember-lifeline', rule, {
       }]
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -210,6 +240,7 @@ ruleTester.run('require-ember-lifeline', rule, {
       }]
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -227,6 +258,7 @@ ruleTester.run('require-ember-lifeline', rule, {
       }]
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -242,6 +274,7 @@ ruleTester.run('require-ember-lifeline', rule, {
       }]
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -259,6 +292,7 @@ ruleTester.run('require-ember-lifeline', rule, {
       }]
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -278,6 +312,7 @@ ruleTester.run('require-ember-lifeline', rule, {
       }]
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -299,6 +334,7 @@ ruleTester.run('require-ember-lifeline', rule, {
       }]
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -314,6 +350,7 @@ ruleTester.run('require-ember-lifeline', rule, {
       }]
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -331,6 +368,7 @@ ruleTester.run('require-ember-lifeline', rule, {
       }]
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -346,6 +384,7 @@ ruleTester.run('require-ember-lifeline', rule, {
       }]
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -363,6 +402,7 @@ ruleTester.run('require-ember-lifeline', rule, {
       }]
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -382,6 +422,7 @@ ruleTester.run('require-ember-lifeline', rule, {
       }]
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -403,6 +444,7 @@ ruleTester.run('require-ember-lifeline', rule, {
       }]
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -418,6 +460,7 @@ ruleTester.run('require-ember-lifeline', rule, {
       }]
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -435,6 +478,7 @@ ruleTester.run('require-ember-lifeline', rule, {
       }]
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -450,6 +494,7 @@ ruleTester.run('require-ember-lifeline', rule, {
       }]
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -467,6 +512,7 @@ ruleTester.run('require-ember-lifeline', rule, {
       }]
     },
     {
+      filename,
       code: `
         import Ember from 'ember';
 
@@ -486,6 +532,7 @@ ruleTester.run('require-ember-lifeline', rule, {
       }]
     },
     {
+      filename,
       code: `
         import Ember from 'ember';