Merge pull request #81 from nlfurniss/fix-jquery-false-positive

Remove Ember from isJQueryCaller check

Author: trentmwillis

AUTHORS.txt

@@ -2,13 +2,16 @@ Burnashov Evgeny <[email protected]>
 Chad Hietala <[email protected]>
 Chris Thoburn <[email protected]>
 David J. Hamilton <[email protected]>
+Edilberto Ruvalcaba <[email protected]>
 Edilberto Ruvalcaba <[email protected]>
 Ilya Radchenko <[email protected]>
 Justin Lan <[email protected]>
 Katie Gengler <[email protected]>
 Kyle Turney <[email protected]>
 Marc Lynch <[email protected]>
+Marc Lynch <[email protected]>
 Mikael Riska <[email protected]>
+Nathaniel Furniss <[email protected]>
 Quinn C. Hoyer <[email protected]>
 Robert Jackson <[email protected]>
 Ryunosuke Sato <[email protected]>

lib/rules/no-jquery-methods.js

@@ -10,12 +10,11 @@ function getMessage(blackListName) {
 }
 
 function isJQueryCaller(node, name = null) {
-  let oName = get(node, 'object.callee.object.name') === 'Ember';
   let pName = get(node, 'object.callee.property.name') === '$';
   let cName = get(node, 'object.callee.name') === '$';
   let lName = get(node, 'object.name') === name;
 
-  return oName || pName || cName || lName;
+  return pName || cName || lName;
 }
 
 function getLocalImportName(node, sourceName) {

tests/lib/rules/no-jquery-methods.js

@@ -56,6 +56,24 @@ ruleTester.run('no-jquery-methods', rule, {
           }
         });`,
       options: [BLACKLISTMETHOD]
+    },
+    {
+      code: `
+        export default Ember.Component({
+          init() {
+            Ember.get().add();
+          }
+        });`,
+      options: [BLACKLISTMETHOD]
+    },
+    {
+      code: `
+        export default Ember.Component({
+          init() {
+            this.$().add();
+          }
+        });`,
+      options: []
     }
   ],
   invalid: [