Fix replacement of renamed/aliased imports (e.g. import { assert as somethingElse } from '@ember/debug')#82
Open
NullVoxPopuli wants to merge 8 commits intoember-cli:mainfrom
Conversation
NullVoxPopuli
force-pushed
the
renamed-imports-unhandled
branch
from
6528a62 to
c5f74d4
Compare
lifeart
approved these changes
Feb 23, 2021
rwjblue
requested changes
Mar 8, 2021
Member
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
This looks good thanks for working on it!
Could you also add usage (of both assert and deprecate) over to this test fixutre as well:
That fixture runs in the ember-cli-babel style configuration, so its a good one to ensure things still work.
rwjblue
changed the title
import { assert as somethingElse } from '@ember/debug')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial Report: emberjs/ember-cli-babel#372