Test against our supported node versions (and fix the babel config for the maintenance-node version (20)) #146
+11
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kategengler
reviewed
Nov 22, 2025
| os: | ||
| - ubuntu-latest | ||
| - windows-latest | ||
| node: |
kategengler
reviewed
Nov 22, 2025
Contributor
Author
|
This will be needed for #49 |
NullVoxPopuli
force-pushed
the
nvp/properImportMetaDirname
branch
from
01e6409 to
c320cfe
Compare
NullVoxPopuli
force-pushed
the
nvp/properImportMetaDirname
branch
from
c320cfe to
11bda68
Compare
NullVoxPopuli
changed the title
Member
|
@NullVoxPopuli this is not an internal change because it fixes a bug with generating an app that doesn't work on the right node version. What versions of the app blueprint has this problem? do we need to backport? |
NullVoxPopuli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks: #119 (which revealed this issue)