Skip to content

Conversation

@gossi
Copy link
Contributor

@gossi gossi commented Jun 25, 2025

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can delete this 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a test that asserts that assert from @ember/debug makes it to the test ouput

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is a nice to have @NullVoxPopuli 🤔 but I wouldn't block too long on that

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a test that asserts that assert from @ember/debug makes it to the test ouput

@NullVoxPopuli I added a test in embroider-build/embroider#2501

Copy link
Contributor

@NullVoxPopuli NullVoxPopuli Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's great! however, we still need tests for the addon-blueprint to make sure we've configured things correctly -- I put up a WIP here: ember-cli/ember-addon-blueprint#66

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a conversation in Discord I have come to my senses

@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Jun 25, 2025
@mansona mansona merged commit b204f62 into ember-cli:main Jun 25, 2025
4 checks passed
@github-actions github-actions bot mentioned this pull request Jun 25, 2025
@mansona mansona changed the title Change Test mode to Development mode Change Test mode to Development mode and fix NODE_ENV in development Jun 25, 2025
@mansona mansona changed the title Change Test mode to Development mode and fix NODE_ENV in development Change Test mode to Development mode and fix NODE_ENV in tests Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants