-
-
Notifications
You must be signed in to change notification settings - Fork 9
Change Test mode to Development mode and fix NODE_ENV in tests #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can delete this 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a test that asserts that assert from @ember/debug makes it to the test ouput
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is a nice to have @NullVoxPopuli 🤔 but I wouldn't block too long on that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a test that asserts that assert from @ember/debug makes it to the test ouput
@NullVoxPopuli I added a test in embroider-build/embroider#2501
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's great! however, we still need tests for the addon-blueprint to make sure we've configured things correctly -- I put up a WIP here: ember-cli/ember-addon-blueprint#66
mansona
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a conversation in Discord I have come to my senses
The sibling to ember-cli/ember-addon-blueprint#64