Skip to content

Conversation

@mansona
Copy link
Member

@mansona mansona commented Nov 9, 2023

No description provided.

@mansona mansona force-pushed the update-ember branch 2 times, most recently from 082bccf to ff22dfc Compare November 13, 2023 11:44
@void-mAlex
Copy link

hasn't this already been done on #741 ?

@Pixelik
Copy link

Pixelik commented Nov 13, 2023

It hadn't actually, I moved @mansona's addition from this PR into my PR recently actually 🙂
Now all tests are passing in my PR except for the Node ones but this is kind of unknown territory for me.. 😕

@tehhowch
Copy link

A benefit of this PR vs #741 is that it isn't a breaking change, so apps which are not yet on node 16 (for whatever reason) can still update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants