Skip to content

Add new recommended rule: template-no-let-reference #1977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmish merged 1 commit into from
Nov 4, 2023
Merged

Add new recommended rule: template-no-let-reference #1977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ rules in templates can be disabled with eslint directives with mustache or html
| [no-empty-glimmer-component-classes](docs/rules/no-empty-glimmer-component-classes.md) | disallow empty backing classes for Glimmer components | ✅ | | |
| [no-tracked-properties-from-args](docs/rules/no-tracked-properties-from-args.md) | disallow creating @tracked properties from this.args | ✅ | | |
| [template-indent](docs/rules/template-indent.md) | enforce consistent indentation for gts/gjs templates | | 🔧 | |
| [template-no-let-reference](docs/rules/template-no-let-reference.md) | disallow referencing let variables in \<template\> | | | |
| [template-no-let-reference](docs/rules/template-no-let-reference.md) | disallow referencing let variables in \<template\> | ✅ | | |

### jQuery

Expand Down
2 changes: 2 additions & 0 deletions docs/rules/template-no-let-reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# ember/template-no-let-reference

💼 This rule is enabled in the ✅ `recommended` [config](https://github.com/ember-cli/eslint-plugin-ember#-configurations).

<!-- end auto-generated rule header -->

Disallows referencing let/var variables in templates.
Expand Down
1 change: 1 addition & 0 deletions lib/recommended-rules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ module.exports = {
"ember/require-tagless-components": "error",
"ember/require-valid-css-selector-in-test-helpers": "error",
"ember/routes-segments-snake-case": "error",
"ember/template-no-let-reference": "error",
"ember/use-brace-expansion": "error",
"ember/use-ember-data-rfc-395-imports": "error"
}
2 changes: 1 addition & 1 deletion lib/rules/template-no-let-reference.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module.exports = {
docs: {
description: 'disallow referencing let variables in \\<template\\>',
category: 'Ember Octane',
recommended: false,
recommended: true,
url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-no-let-reference.md',
},
fixable: null,
Expand Down
1 change: 1 addition & 0 deletions tests/__snapshots__/recommended.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ exports[`recommended rules has the right list 1`] = `
"require-tagless-components",
"require-valid-css-selector-in-test-helpers",
"routes-segments-snake-case",
"template-no-let-reference",
"use-brace-expansion",
"use-ember-data-rfc-395-imports",
]
Expand Down