Skip to content

Include static partial names in the list of renderables.#28

Open
rwjblue wants to merge 1 commit intomasterfrom
deal-with-partials
Open

Include static partial names in the list of renderables.#28
rwjblue wants to merge 1 commit intomasterfrom
deal-with-partials

Conversation

@rwjblue
Copy link
Member

@rwjblue rwjblue commented Apr 24, 2016

Addresses #27.


There are still some open questions about where exactly a localized partial would go in the new proposal.

Given the following route template (and assuming it was the only usage of the partial):

{{! app/templates/posts/show.hbs }}

<div>
  {{partial "post-display"}}
</div>

Currently, the migrator will make the following layout:

src/ui/routes/posts/show/template.hbs
src/ui/routes/post-display.hbs

This seems non-ideal, but I am unsure what should actually happen here...

@iezer
Copy link
Contributor

iezer commented Mar 31, 2017

According to the spec, the file should go into src/ui/partials/post-display.hbs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants