Remove deprecated features for ember-cli-fastboot v3 release #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiwiupover
suggested changes
Apr 5, 2021
Member
kiwiupover
left a comment
kiwiupover
left a comment
There was a problem hiding this comment.
@xg-wang test-packages/example-addon should not be a submodule. I think it has a .git folder that needs to be deleted.
Member
Author
|
@kiwiupover yea, turns out if I rm -rf .git after adding it, it is still being tracked as submodule 🤦🏼 |
Member
|
@xg-wang this is better |
kiwiupover
approved these changes
Apr 5, 2021
Member
|
@xg-wang Thanks. |
* `@service('fastboot')`
* `cookies` -> `this.fastboot.request.cookies`
* `headers` -> `this.fastboot.request.headers`
* `host` -> `this.fastboot.request.host`
* `ember-addon.fastBootDependencies` -> `ember-addon.fastbootDependencies` (the lowercased 'b')
* `app/initializers|instance-initialzers/fastboot` -> `fastboot/initializers|instance-initializers/`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@service('fastboot')cookies->this.fastboot.request.cookiesheaders->this.fastboot.request.headershost->this.fastboot.request.hostember-addon.fastBootDependencies->ember-addon.fastbootDependencies(the lowercased 'b')app/initializers|instance-initialzers/fastboot->fastboot/initializers|instance-initializers/