Skip to content

Fix styles for tips in ember-data docs, fix tables in markdown #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2025
Merged

Fix styles for tips in ember-data docs, fix tables in markdown #958

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
112daf0
Fix styles for tips in ember-data docs, fix tables in markdown
kategengler Aug 27, 2025
86bfc88
Update app.css
MinThaMie Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions app/styles/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,31 @@ section.event {
margin: var(--spacing-2);
}

/* Ember data uses styled elements in markdown blocks that conflict with the
default styles for blockquotes (because of ::before block that has an
absolutely positioned quote mark).
*/
blockquote[style]::before {
all: initial;
}

/* Styles for tables (from markdown)
Should probably be upstreamed to ember-styleguide
*/
table {
text-align: left;
border-collapse: collapse;
}

table tr {
border-bottom: 1px solid var(--color-gray-300);
}

table th,
table td {
padding: var(--spacing-1);
}

@media (width >= 845px) {
.es-header {
padding: 0 var(--spacing-4);
Expand Down