Remove unused dependencies - #552
Open
NullVoxPopuli-ai-agent wants to merge 1 commit into
Open
Conversation
broccoli-merge-trees, static-postcss-addon-tree, ember-named-blocks-polyfill, lodash.get, and ember-native-dom-helpers are declared but not referenced anywhere in the addon, dummy app, or tests. Named blocks are native in all supported Ember versions, so the polyfill was inert. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for ember-styleguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was referenced Aug 6, 2026
Draft
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes five dependencies that are declared in
package.jsonbut not referenced anywhere in the addon, dummy app, or tests:broccoli-merge-treesstatic-postcss-addon-treeember-named-blocks-polyfill(named blocks are native in all supported Ember versions, so the polyfill was inert)lodash.getember-native-dom-helpersbroccoli-funnelstays (used bytreeForPublicinindex.js), andember-sinonstays (it provides thesinonmodule imported byes-button-test).First step of an incremental path toward a v2 addon, following the small-PRs approach from Keeping a clean git history. #551 is the reference for where this is heading.
Test plan
pnpm lint(js, hbs, css, format) passespnpm exec ember test— 27 tests, 0 failures (same as master baseline)🤖 Generated with Claude Code