Replace @ember/render-modifiers with ember-modifier - #553
Open
NullVoxPopuli-ai-agent wants to merge 1 commit into
Open
Replace @ember/render-modifiers with ember-modifier#553NullVoxPopuli-ai-agent wants to merge 1 commit into
NullVoxPopuli-ai-agent wants to merge 1 commit into
Conversation
The one usage was didInsert/willDestroy in es-header-navbar-link. A single modifier() now captures the element and returns the listener cleanup, which also removes the no-at-ember-render-modifiers lint suppressions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for ember-styleguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Draft
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
@ember/render-modifierswithember-modifier, the direction the render-modifiers README itself recommends.The one usage was in
es-header-navbar-link.gjs:{{didInsert}}to capture the element and{{willDestroy}}to remove listeners. Both are now a singlemodifier()with its cleanup returned from the setup function, so the element capture and the teardown live in one place. This also lets us drop theno-at-ember-render-modifierslint suppressions.One step of an incremental path toward a v2 addon (see #551 for where this is heading), kept deliberately minimal per Keeping a clean git history.
Test plan
pnpm lint(js, hbs, css, format) passespnpm exec ember testpasses (dropdown open/close tests cover this component)🤖 Generated with Claude Code