Modernize integration test templates - #559
Draft
NullVoxPopuli-ai-agent wants to merge 5 commits into
Draft
Conversation
broccoli-merge-trees, static-postcss-addon-tree, ember-named-blocks-polyfill, lodash.get, and ember-native-dom-helpers are declared but not referenced anywhere in the addon, dummy app, or tests. Named blocks are native in all supported Ember versions, so the polyfill was inert. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The one usage was didInsert/willDestroy in es-header-navbar-link. A single modifier() now captures the element and returns the listener cleanup, which also removes the no-at-ember-render-modifiers lint suppressions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
import { service } is the recommended form since Ember 4.1; inject is
removed in newer majors.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The only use was a single spy asserting es-button's onClicked fires; qunit's assert.step/verifySteps covers that without a dependency. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Swaps the deprecated htmlbars-inline-precompile import for ember-cli-htmlbars and converts es-button/es-card test invocations to angle brackets. Templates under the old import were invisible to ember-template-lint; the new import brings them under lint and the angle-bracket conversion makes them pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for ember-styleguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Draft
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernizes the integration test templates:
import hbs from 'htmlbars-inline-precompile'→import { hbs } from 'ember-cli-htmlbars'(six files)es-button-testandes-card-test({{es-button label=this.label}}→<EsButton @label={{this.label}} />, etc.)These go together: templates under the old import were invisible to
ember-template-lint, so the curly invocations never got flagged. The new import brings them under lint, and the angle-bracket conversion makes them pass — no rule allowances needed.Note
Draft until #555 lands —
es-button-test's import block is touched by both, so this stacks on it. Only the last commit is the reviewable diff here.Part of the incremental path toward a v2 addon (#551 is the reference).
Test plan
pnpm lint(js, hbs, css, format) passes — including the newly-linted test templatespnpm exec ember test— 27 tests, 0 failures🤖 Generated with Claude Code