Let consuming apps own their postcss config - #560
Open
NullVoxPopuli-ai-agent wants to merge 1 commit into
Open
Conversation
The included hook overwrote app.options.postcssOptions unconditionally. It is now only a default, so an app that configures postcss itself wins. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for ember-styleguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was referenced Aug 7, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
includedhook currently overwritesapp.options.postcssOptionsunconditionally, so a consuming app can never own its postcss config. This makes the injection a default instead: apps that don't configure postcss keep exactly today's behavior, and apps that do configure it win.This is the unblocking step for the CSS part of the v2 path (#551): once consumers (ember-website et al.) declare their own postcss config, the injection can be removed entirely in a later step.
Test plan
pnpm lint(js, hbs, css, format) passespnpm exec ember test— 27 tests, 0 failures (dummy app sets no postcssOptions, exercising the default branch)🤖 Generated with Claude Code