Skip to content

feat: lazy load Highcharts #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IgnaceMaes merged 2 commits into from
May 1, 2025
Merged

feat: lazy load Highcharts #1087

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10927a1
feat: lazy load highcharts
IgnaceMaes Feb 21, 2024
07f24b0
Merge branch 'ember-learn:main' into lazy-load-highcharts
IgnaceMaes May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions app/modifiers/draw-chart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import { registerDestructor } from '@ember/destroyable';
import merge from 'deepmerge';
import Modifier from 'ember-modifier';
import Highcharts from 'highcharts';
import highchartsAccessibilty from 'highcharts/modules/accessibility';

const optionsForAllCharts = {
credits: {
Expand All @@ -21,26 +19,33 @@ const optionsForAllCharts = {
};

export default class DrawChartModifier extends Modifier {
constructor(owner, args) {
super(owner, args);
highcharts;

this.initializeHighcharts();
}

modify(element, [chart]) {
async modify(element, [chart]) {
if (!chart) {
return;
}

await this.initializeHighcharts();

this.drawChart({ chart, element });

registerDestructor(this, this.destroyChart.bind(this));
}

initializeHighcharts() {
highchartsAccessibilty(Highcharts);
async initializeHighcharts() {
if (this.highcharts) {
return;
}

const { default: highcharts } = await import('highcharts');
const { default: highchartsAccessibilty } = await import(
'highcharts/modules/accessibility'
);

highchartsAccessibilty(highcharts);

this.highcharts = Highcharts;
this.highcharts = highcharts;
this.highcharts.setOptions(optionsForAllCharts);
}

Expand Down