Skip to content

update twitter references to x #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

BornDeleuze
Copy link

In response to this issue

All lowercase instances of twitter replaced with x, while uppercase instances replaced with X. The data from surveys in csv files were not changed.

This update will not work without the changes to the styleguide here

Copy link

netlify bot commented Aug 11, 2025

Deploy Preview for ember-website ready!

Name Link
🔨 Latest commit 346c016
🔍 Latest deploy log https://app.netlify.com/projects/ember-website/deploys/689d5f1b86fe6400084936b5
😎 Deploy Preview https://deploy-preview-1168--ember-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@BornDeleuze
Copy link
Author

So I figured I'd try to fully test it out, which I hadn't done as it's been a while since linking style repos. I went ahead and linked this project with ember-styleguides locally with pnpm link, and noticed we didn't have a twitter svg on this site. I added that in here and it looks pretty good.
Screenshot 2025-08-13 at 9 11 39 PM
To get this to play nicely locally I had to add ember-svg-jar as a dependency, but I believe that this isn't necessary for prod, so did not include that. I'm not fully sure what the build process is so I could be off!

The footer also has an x svg, but this is loaded from ember-styleguides. I could not get that logo to load properly, so added a review on that PR to use the svg i added here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant