-
-
Notifications
You must be signed in to change notification settings - Fork 518
Tracking branch for GJS migration #2117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
78 commits
Select commit
Hold shift + click to select a range
dd7a318
convert quick start to gjs
mansona f6e4ac9
Merge pull request #2113 from ember-learn/quickstart-gjs
mansona 9d1b806
start converting a couple route files
locks b37e495
update all handlebars code blocks to gjs
mansona 9517054
add a zoey says cta to warn about --strict
mansona 7f94eb7
Updated core concepts / components to use gjs
tcjr 9c5de38
Review updates:
tcjr f77f313
Typos and whitespace
tcjr 98e4630
Updated autotracking in depth to use gjs
tcjr e9bbb8f
Properly escape tag in cta note
tcjr 7bae6d4
Update guides/release/components/built-in-components.md
tcjr 2c9aa75
Update guides/release/components/built-in-components.md
tcjr 4084766
Update guides/release/components/built-in-components.md
tcjr b0433a3
Update guides/release/components/component-state-and-actions.md
tcjr 6f86d10
Update guides/release/components/component-state-and-actions.md
tcjr 0e14105
Update guides/release/components/helper-functions.md
tcjr 2076f05
Update guides/release/components/helper-functions.md
tcjr 6dc6784
Apply suggestions from code review
tcjr d9a0fb8
Apply suggestions from code review
tcjr 48d9f8a
Apply suggestions from code review
tcjr 0518d16
Updated patterns for components to use gjs
tcjr 83ea5fb
Fixed links to some built-in functions
tcjr ab28839
Converted accessibility/page-template-considerations to use gjs
tcjr ebac76d
Converted services to use gjs
tcjr 41b3e0d
Converted typescript invokables to use gts (no diff indicators)
tcjr 8ff7057
Converted typescript gotchas to use gts
tcjr ef8b5f3
Converted typescript testing to use gts
tcjr 73ffab2
Updated diff markers to gts snippets
tcjr 2e88adf
Converted models to use gjs
tcjr 0b29b30
Updated patterns for actions to use gjs
tcjr a0ae294
Updated rendering values to use gjs - WIP, imports
tcjr 5591df4
Resolved TODO
tcjr 23453dd
Removed imports; updated text to refer to helper/modifier/component h…
tcjr fd273c9
apply changes from review
mansona bc9049e
fix linting
mansona b39f183
Merge pull request #2124 from tcjr/gjs-components
mansona f653054
Merge remote-tracking branch 'origin/master' into merge-main
mansona 90de3a1
Merge pull request #2131 from ember-learn/merge-main
mansona 55a2d5a
Changed import paths
tcjr 760e43b
Changed import paths
tcjr dc2903a
spelling
tcjr 41e2655
Merge branch 'gjs' into gjs-misc
tcjr 3f553bd
Merge branch 'gjs' into gjs-in-depth
tcjr 3341e69
Removed unused reference
tcjr f540897
Added hash helper when used
tcjr 1e26970
Apply suggestion from @kategengler
tcjr 17e91a7
Apply suggestion from @kategengler
tcjr 87142e1
Apply suggestions from code review
mansona 4cf7ec6
Merge pull request #2126 from tcjr/gjs-misc
mansona 8866067
Merge remote-tracking branch 'origin/gjs' into gjs-in-depth
mansona e9f4ef2
apply review changes done live in Ember Learning Meeting
mansona 8adf032
Merge pull request #2127 from tcjr/gjs-in-depth
mansona 20db8af
Merge remote-tracking branch 'origin/master' into merge-master
mansona 2a11756
Merge pull request #2141 from ember-learn/merge-master
mansona cf2d4be
Merge branch 'gjs' into gjs-routing
mansona f3575c8
update last references to hbs
mansona f220607
Merge pull request #2118 from ember-learn/gjs-routing
mansona 404e81c
minor changes to runloop
mansona c275bbd
update anatomy-of-an-ember-app to gjs
mansona 1a27b39
catch the last few references to Ember.run
mansona 11c0041
fix lint
mansona eb48be6
Merge pull request #2147 from ember-learn/ember-app
mansona 59163c7
Merge pull request #2146 from ember-learn/runloop
mansona d06abdd
updating testing-components to gjs
mansona d8ff613
update testing tools to gjs
mansona cc45c41
Merge pull request #2149 from ember-learn/testing-tools
mansona 2d9b0b0
stop referring to QUnit.test
mansona 5b0a0e5
update to not use this.set or assert.equal
mansona 2597ecc
fix lint and tests
mansona 7257532
Merge pull request #2148 from ember-learn/testing-components
mansona 8f03818
Merge remote-tracking branch 'origin/master' into merge-master
mansona 2baf046
Merge pull request #2150 from ember-learn/merge-master
mansona e401fba
Strict mode (#263)
ember-tomster 09cad6b
Merge pull request #2151 from ember-learn/gjs-tutorial
mansona fa48015
Merge remote-tracking branch 'origin/master' into merge-master
mansona bc06c7c
Merge pull request #2153 from ember-learn/merge-master
mansona 16565b5
show the gjs warning banner on 6.7.0
mansona e59d0f5
Merge pull request #2159 from ember-learn/show-banner
mansona File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -252,3 +252,4 @@ websocket | |
| working-with-html-css-and-javascript | ||
| yay | ||
| ZEIT | ||
| userQuestion | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't match the string used above on line 39. Should be
My TitleThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah looks like the previous code example did append
@model.title " - Site Title"